fix(megamenu-tab): change default value override method #12088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-blum
requested review from
m4olivei,
bruno-amorim,
marcelojcs and
Valentin-Sorin-Nicolae
and removed request for
a team
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
m4olivei
added
the
Ready to merge
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
### Related Ticket(s) Closes #12087 (partially, see also #12088) ### Description Fixes the following error reported when using react wrapped components: ``` Error: The following properties on element c4d-locale-search will not trigger updates as expected because they are set using class fields: inputTimeout. Native class fields and some compiled output will overwrite accessors used for detecting changes. See https://lit.dev/msg/class-field-shadowing for more information. ``` ### Changelog **Changed** - Declare `inputTimeout` class property of `ThrottledInputMixin` as abstract, relying on children to implement. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
|
Hey there! This issue/pull request was referenced in recently released v2.16.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Closes #12087
Description
Updates the method by which the megamenu-tab component overrides inherited values.
Testing
I'm not sure there's a good way to test this change and its impact on projects using react-wrapped components. For now, we should focus on making sure not to introduce regressions into the web components.
Changelog
Changed